Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for PR_FILTER=auto_merge #240

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

chinthakagodawita
Copy link
Owner

expect(needsUpdate).toEqual(true);
expect(comparePr.isDone()).toEqual(true);
expect(config.pullRequestFilter).toHaveBeenCalled();
expect(config.excludedLabels).toHaveBeenCalled();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this excludedLabels expect isn't related to this test right? we can probs remove it?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops yea, that's what I get for copy-pasting! Just removed it

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #240 (b5212fa) into master (51eed1b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          593       611   +18     
  Branches       116       119    +3     
=========================================
+ Hits           593       611   +18     
Impacted Files Coverage Δ
src/autoupdater.ts 100.00% <100.00%> (ø)
src/config-loader.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51eed1b...b5212fa. Read the comment docs.

Copy link
Collaborator

@anarast anarast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chinthakagodawita chinthakagodawita merged commit 1be90ce into master Oct 23, 2021
@chinthakagodawita chinthakagodawita deleted the automerge-support branch October 23, 2021 23:15
@chinthakagodawita
Copy link
Owner Author

Released in v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auto_merge to PR_FILTER
2 participants